[Kde-pim] Review Request 117696: ResourceBase: Don't call retrieveItems with empty remoteId

Dan Vrátil dvratil at redhat.com
Wed Apr 23 08:13:46 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117696/#review56245
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On April 22, 2014, 11:05 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117696/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 11:05 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ResourceBase: Don't call retrieveItems with empty remoteId
> 
> This was caught in the imap resource, but we can at least fix this in
> ResourceBase since a Resource should never be able to fetch items for a
> collection without remoteId.
> 
> 
> Diffs
> -----
> 
>   akonadi/resourcebase.cpp 435dbd897dd1f7674aaead3c16ddb3f1ce32ef30 
> 
> Diff: https://git.reviewboard.kde.org/r/117696/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list