[Kde-pim] Review Request 117244: Coding Style for tagmodel.h

[Guy Maurel]

> On April 9, 2014, 8:34 a.m., Dan Vrátil wrote:
> > akonadi/tagmodel.h, line 78
> > <https://git.reviewboard.kde.org/r/117244/diff/1/?file=262119#file262119line78>
> >
> >     In other reviews you've been adding argument names, maybe add them here too?

Right.
In other reviews I found some proper names in the *.cpp files, which are here not present.
I wonder about the declaration of two "not used" formal parameter variables.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117244/#review55258
-----------------------------------------------------------


On March 31, 2014, 4:32 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117244/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 4:32 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/tagmodel.h 74f1d31 
> 
> Diff: https://git.reviewboard.kde.org/r/117244/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/