[Kde-pim] Review Request 117689: Netherlands: Koninginnedag is now Koningsdag

[Mark Gaiser]

(Resend to list)
Op 23 apr. 2014 09:05 schreef "Thijs Kinkhorst" <thijs at kinkhorst.com>:

> On Wed, April 23, 2014 00:26, Mark Gaiser wrote:
> > Op 22 apr. 2014 18:33 schreef "Thijs Kinkhorst" <thijs at kinkhorst.com>:
> >>
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://git.reviewboard.kde.org/r/117689/
> >> -----------------------------------------------------------
> >>
> >> Review request for KDEPIM-Libraries.
> >>
> >>
> >> Bugs: 331219
> >>     http://bugs.kde.org/show_bug.cgi?id=331219
> >>
> >>
> >> Repository: kdepimlibs
> >>
> >>
> >> Description
> >> -------
> >>
> >> Starting with 2014, Queen's Day will be King's Day and celebrated
> >> on the 27th of April, unless that's a Sunday, then it will be a
> >> Saturday.
> >>
> >> http://nl.wikipedia.org/wiki/Koningsdag_%28Nederland%29#Datum
> >> http://en.wikipedia.org/wiki/Koningsdag#Willem-Alexander
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   kholidays/holidays/plan1/holiday_nl_nl 3027170
> >>   kholidays/holidays/plan2/holiday_nl_nl fe9f263
> >>   kholidays/tests/holiday_xx_xx_Old 95e1e24
> >>
> >> Diff: https://git.reviewboard.kde.org/r/117689/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >>
> >> Thanks,
> >>
> >> Thijs Kinkhorst
> >>
> >> _______________________________________________
> >> KDE PIM mailing list kde-pim at kde.org
> >> https://mail.kde.org/mailman/listinfo/kde-pim
> >> KDE PIM home page at http://pim.kde.org/
> >
> > (Reply send to list instead of review request comment)
> >
> > It's not this simple. I had a roughly similar patch.
> >
> > The calendar stuff is meant to work if you go back in time as well. Now
> if
> > to go back then you suddenly see a "Koningsdag" for the years back where
> > it
> > still should be "Koninginnedag" which is not the result as it should be.
> >
> > So the kholidays parsing and library should be modified to allow for an
> > event to end at a certain point in time. And for event to begin from a
> > certain point in time.
> >
> > Cool huh, changing holidays ;-)
>
> Alright, I can imagine that it takes some work to implement that.
>
> However, if we change the data file to list "27 april", the data file will
> give the correct result  upto 2025(!). So maybe make the change anyway, so
> at least the comming ten years it will be correct, and then somewhere in
> those ten years implement the code changes :)
>
>
> Thijs
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/