[Kde-pim] Review Request 117849: Improve KMail's Create Todo/Event widgets

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117849/#review56783
-----------------------------------------------------------


I looked at label "Todo List:"/"Calendar:" it will take place and it will reduce lineedit size when we have 3 columns.
So I think it's not a good idea.
We already have a label "todo" "event" so it's enough for me.

- Laurent Montel


On April 28, 2014, 3:45 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117849/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 3:45 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Couple improvements to the widgets:
> 
> 1) added "Save" button (you can still create event/todo just by hitting enter in the edit line, but that's not easily discoverable (took me a while to figure that out)
> 2) removed the close tool button and instead added "Close" button next to the "Save" one, so that we create line of buttons
> 3) added "Open Editor" button which opens the full-features incidence-editor. This is useful when you want to sent for instance a reminder - otherwise you would have to start KOrganizer to edit the just created event
> 4) fixed TodoEdit to actually close after accepting
> 5) added label to the collection combobox
> 6) slightly modified the layout
> 7) added code to EventEdit to automatically update endDateTimeEdit, when a change in startDateTimeEdit would cause the dtEnd to be before dtStart (unfortunately that does not work because the KDateTimeEdit is broken, I'll put up a patch for kdelibs later).
> 
> 
> Diffs
> -----
> 
>   messageviewer/CMakeLists.txt aa9034c 
>   messageviewer/tests/eventedittest.cpp 0c7ea35 
>   messageviewer/tests/todoedittest.cpp e8fe51e 
>   messageviewer/widgets/eventedit.h c1b6a99 
>   messageviewer/widgets/eventedit.cpp be52916 
>   messageviewer/widgets/todoedit.h f0d0774 
>   messageviewer/widgets/todoedit.cpp 472ba00 
> 
> Diff: https://git.reviewboard.kde.org/r/117849/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/28/8f9b5c1a-b71c-4805-b4ad-d0f3f644df18__kmail-old.png
> Now
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/04/28/a0647751-b97b-4a75-a652-85bf6ba6667d__kmail-new.png
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/