[Kde-pim] Review Request 115846: kontact summary view

[Eugenio Accorsi]

> On April 3, 2014, 11:34 p.m., Sergio Luis Martins wrote:
> > Can you give an example of an event that isn't displayed ( start and end date ).
> > Bug 278956 was because calendars weren't selected, I've fixed that for 4.11 or 4.12, so your bug must be different.
> > 
> > I would like to reproduce it first before trying your patch.

Ok, these are bugs in the summary view that i tried to patch (I used some random hour to try to make bugs more clear):
It is 10 am.
1. If there is an event from 7 am to 8 it is shown with label "now". That should not be shown because it is a past event.
2. A multiday event that started yesterday at 9 am and ends tomorrow at 6 pm is shown with a wrong hour label "12 am - 6 pm". That should be all day.
3. A multiday event that starts in the following days is not shown at all.
4. A multiday event that starts today at 9 am and ends tomorrow at 11 am is shown with a wrong hour label "9 am - 11 am". Should be 9 am and 11:59 pm.
5. Event are not shown sequentially in time. I think they are organized with the creation time.
6. Recurring events that do not have a next date are shown with a wrong label "next /:00" (or sometimes just "next"). That label should be empty.

I know that 2. and 4. are ok if you read them like this "start today at midnight, end tomorrow at 6 pm" and "start today at 9 am, end tomorrow at 11 am" but that should be more clear. It is impossible to understand if you have the same start and end hour (11:00 AM - 11:00 AM).


- Eugenio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115846/#review54964
-----------------------------------------------------------


On March 13, 2014, 4:08 p.m., Eugenio Accorsi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115846/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 4:08 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Bugs: 278956
>     http://bugs.kde.org/show_bug.cgi?id=278956
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> since i use kontact very often i tried to make the summary view work as expected.
> the only problem with this patch is the special event plugin.
> maybe someone with better experience with akonadi can steer me in the right direction..
> i changed the old implementation because it doesn't work for every contact.
> 
> 
> Diffs
> -----
> 
>   kontact/plugins/korganizer/summaryeventinfo.h a9bb775 
>   kontact/plugins/korganizer/summaryeventinfo.cpp 00c9906 
> 
> Diff: https://git.reviewboard.kde.org/r/115846/diff/
> 
> 
> Testing
> -------
> 
> in the special-occasion plugin enabling the search for special events in contacts will result in high cpu usage by nepomuk.
> i tried also with master but it does not find any contacts.
> the summary event plugin works as expected.
> 
> 
> Thanks,
> 
> Eugenio Accorsi
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/