[Kde-pim] Review Request 117642: Fixes MailWebView::scrollToAnchor

Lindsay Mathieson lindsay.mathieson at gmail.com
Sat Apr 19 15:16:24 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117642/
-----------------------------------------------------------

Review request for KDEPIM.


Bugs: 333619
    http://bugs.kde.org/show_bug.cgi?id=333619


Repository: kdepim


Description
-------

The DOM code in MailWebView::scrollToAnchor no longer seems to work. However there is a QT api call in QWebFrame::scrollToAnchor() introduced in QT 4.7 that implements the functionality needed.


Diffs
-----

  messageviewer/viewer/mailwebview_webkit.cpp d39345b 

Diff: https://git.reviewboard.kde.org/r/117642/diff/


Testing
-------

Built, installed and tested with HTML messages that have links to inline Anchors in their body. The messages scrolled to display the anchor position as expected.


Thanks,

Lindsay Mathieson

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list