[Kde-pim] Review Request 117231: Coding Style for item.h

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117231/#review55647
-----------------------------------------------------------



akonadi/item.h
<https://git.reviewboard.kde.org/r/117231/#comment38733>

    In this case I would say we keep the unnamed argument. The comment suggests that it is not a real argument, just there for make the overload distinguishable.
    Same for the other occurences later on



akonadi/item.h
<https://git.reviewboard.kde.org/r/117231/#comment38734>

    not sure if needed but better add a Q_UNUSED for e


- Kevin Krammer


On March 31, 2014, 4:29 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117231/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 4:29 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi/item.h 9aace94 
> 
> Diff: https://git.reviewboard.kde.org/r/117231/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/