[Kde-pim] Review Request 117471: ItemSync: Use batch processing and allow throttling
Christian Mollekopf
chrigi_1 at fastmail.fm
Wed Apr 16 12:25:53 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117471/
-----------------------------------------------------------
(Updated April 16, 2014, 11:25 a.m.)
Review request for KDEPIM-Libraries.
Repository: kdepimlibs
Description
-------
ItemSync: Use batch processing and allow throttling
With this patch we process the items in batches and gives resources the
possiblity to throttle the retrieval of messages using the
readyForNextBatch signal. This way we avoid using huge queries and
loading all items into memory, making the whole process a lot less
resource intensive, and make it work for large folder.
Diffs (updated)
-----
akonadi/itemsync.h 32166d7154b0a9a5131b0dd215c0a5a75b2a67dd
akonadi/itemsync.cpp 421c14a027836800bab1e62ca466d68475c71e1f
akonadi/resourcebase.h 01f86a84c5fd78b8dfcabf638a881759b159f04c
akonadi/resourcebase.cpp 4e5b1e9289d1cbfba42490961dab78ebaad8a586
akonadi/tests/itemsynctest.cpp 4999c03abb25f3e1cf767b287dcf7698693745e9
Diff: https://git.reviewboard.kde.org/r/117471/diff/
Testing
-------
I adapted the imap resource accordingly and I can now sync 200k mail folder with the bottleneck being mysql (as it should) and no significant cpu or memory usage by akonadi-server or the imap resource. Also, unittests.
Thanks,
Christian Mollekopf
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list