[Kde-pim] Review Request 112543: reorder initialisation for imapstreamparser.cpp

[Guy Maurel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112543/
-----------------------------------------------------------

(Updated Sept. 6, 2013, 3:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Akonadi, Dan Vrátil and Kevin Krammer.


Description
-------

after you wish to put the initialisation above, the gcc says:
In file included from akonadi/server/src/imapstreamparser.cpp:21:0:
akonadi/server/src/imapstreamparser.h: In constructor 'Akonadi::ImapStreamParser::ImapStreamParser(QIODevice*)':
akonadi/server/src/imapstreamparser.h:268:10: warning: 'Akonadi::ImapStreamParser::m_peeking' will be initialized after [-Wreorder]
     bool m_peeking;
          ^
akonadi/server/src/imapstreamparser.h:262:16: warning:   'QIODevice* Akonadi::ImapStreamParser::m_socket' [-Wreorder]
     QIODevice *m_socket;
                ^
akonadi/server/src/imapstreamparser.cpp:33:1: warning:   when initialized here [-Wreorder]
 ImapStreamParser::ImapStreamParser( QIODevice *socket )
 ^

As the .h file is written *before* the .cc file, I made the changes in the last one.


Diffs
-----

  server/src/imapstreamparser.cpp 1f1ab34 

Diff: http://git.reviewboard.kde.org/r/112543/diff/


Testing
-------


Thanks,

Guy Maurel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/