[Kde-pim] Review Request 112798: coding style for session

[Dan Vrátil]

> On Sept. 18, 2013, 7:47 p.m., Dan Vrátil wrote:
> > asapcat/session.cpp, line 111
> > <http://git.reviewboard.kde.org/r/112798/diff/1/?file=190451#file190451line111>
> >
> >     Missed one space here: ))
> 
> Guy Maurel wrote:
>     well! we never speak about () surrounding an expression.
>     I think, it is a good idea.
>     Do you want this everywhere?

I don't think we run into this before in Akonadi, but I think the spaces make sense in this case - from my POV it's equivalent to if ( ( a == 1 ) || ( b == 2 ) ) and we added spaces there.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112798/#review40294
-----------------------------------------------------------


On Sept. 18, 2013, 7:22 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112798/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 7:22 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> next job for akonadi/asapcat/
> 
> 
> Diffs
> -----
> 
>   asapcat/session.h 8dc6dab 
>   asapcat/session.cpp c83ee4b 
> 
> Diff: http://git.reviewboard.kde.org/r/112798/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/