[Kde-pim] Review Request 112968: kmail: improve the layout of the Composer - General tab

[Jonathan Marten]

> On Sept. 27, 2013, 10:25 p.m., Sandro Knauß wrote:
> > File Attachment: Screen shot - before
> > <http://git.reviewboard.kde.org/r/112968/#fcomment117>
> >
> >     why you removed Maximum number of recipient editor lines?
> 
> Laurent Montel wrote:
>     because it was rename to "maximum number of reply to all recipient".
>     I think that we are limited even if we write a new emails.
> 
> Jonathan Marten wrote:
>     It doesn't seem to be an absolute limit on the number of recipients that can be entered by the user, it only affects the number taken for a reply-to-all (in RecipientsEditor::setRecipientString() in kdepim/messagecomposer/recipient/recipientseditor.cpp) and the number that can be accepted from the recipient picker (in RecipientsPicker::pick() in kdepim/messagecomposer/recipient/recipientspicker.cpp).  It doesn't affect adding recipient lines by manually entering addresses, there is no limit there.
>     
>     I think this is a sensible use of the limit as it covers the most common user mistake - clicking "Reply to All" on a widely distributed email - and so captioned accordingly.
>     
>     Setting lots of recipients may be necessary in some cases - and having to manually add them or use multiple invocations of the picker at least makes them think.  But if it was intended that this should be a hard limit then the fix is elsewhere - in which case we may as well just adopt the enterprise "Warn if the number of recipients is more than..." option.
>
> 
> Laurent Montel wrote:
>     So I will fix in code because it's logical to define a limit for reply and send.
>

Ok, in that case I'll rename the option "Maximum number of recipient entries" and change the help text accordingly.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112968/#review40926
-----------------------------------------------------------


On Sept. 27, 2013, 3:56 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112968/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 3:56 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The "Configure KMail - Composer - General" dialogue tab has probably been much added to over time, and now resembles the aftermath of an explosion in a checkbox factory.  None of the spin boxes or buttons near the bottom line up, and there is inconsistent punctuation.
> 
> This revised layout uses group boxes to split the options up into categories, and lines up the buttons and spin boxes using grid layouts internal to the group boxes.  All widgets have a tool top and what's this text - most useful for some of the more obscure options, e.g. the new "Improve plain text..." option.
> 
> The layout works for both the normal and enterprise builds (see the two "after" screen shots).
> 
> 
> Diffs
> -----
> 
>   kmail/configuredialog/configuredialog.cpp 81d50c4 
>   kmail/settings/kmail.kcfg.cmake e620fc2 
>   messagecomposer/settings/messagecomposer.kcfg.cmake 2c0b3e6 
> 
> Diff: http://git.reviewboard.kde.org/r/112968/diff/
> 
> 
> Testing
> -------
> 
> Built kmail with these changes.  Checked appearance, layout and operation of all buttons.
> 
> 
> File Attachments
> ----------------
> 
> Screen shot - before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-before.png
> Screen shot - after, normal build
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-after-normal.png
> Screen shot - after, enterprise build
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-after-enterprise.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/