[Kde-pim] Review Request 112257: Add kontact dock status to session restore

[Jos Poortvliet]

I for one appreciate this fix, even though I try to wean myself off of the
systray as it has bugs that most likely won't get fixed due to the
workspace devs' dislike of the stray... kmail needs a widget with some
systray functions... :'(


> On Aug. 30, 2013, 11:27 p.m., Dan Vrátil wrote:
> > Without really checking the code, this might not work as expected,
because Kontact itself does not have any tray icon. The tray icons are
provided by KMail or Akregator (or others), so even if you restore this
value, KMail can still decide to show the window anyway (because it does
not know about this).

I looked into this - kmail only restores its docked state if its the
toplevel window.


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112257/#review38931
-----------------------------------------------------------


On Aug. 25, 2013, 10:36 a.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112257/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2013, 10:36 a.m.)
>
>
> Review request for KDEPIM and Lindsay Mathieson.
>
>
> Description
> -------
>
> Kontacts dock status in the system tray is not preserved on session
> restore. This patch saves the docs status and checks it on session
> restore.
>
>
> Diffs
> -----
>
>   kontact/src/main.cpp 54bb1b7
>   kontact/src/mainwindow.cpp 6e8f09d
>
> Diff: http://git.reviewboard.kde.org/r/112257/diff/
>
>
> Testing
> -------
>
> Logging out/in with kontact displayed and hidden in the system tray. Both
states were correctly restored.
> Additionaly, checked that std restore from restarting kontact was working
correctly.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/