[Kde-pim] Review Request 109764: Refactor messagecomposer::Composer::composeStep2

Commit Hook null at kde.org
Tue Sep 24 16:59:16 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109764/#review40710
-----------------------------------------------------------


This review has been submitted with commit 8949f893f2198c8a9ac106ed289f5e2cacdb2646 by Sandro Knauß to branch master.

- Commit Hook


On March 27, 2013, noon, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109764/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, noon)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> There are many different function that perform the signing and
> encrypting. To make it more easier all the chaining through the Sign and
> EncyptionJobs are now pushed into composeStep2.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer.h 2f6edf2ba2dd2fd44d0b24d2c27b2521bceb3177 
>   messagecomposer/composer.cpp 763cd02afedda8ffa0fce0c3c997d5bf755c2b20 
> 
> Diff: http://git.reviewboard.kde.org/r/109764/diff/
> 
> 
> Testing
> -------
> 
> create GPG (inline and MIME) encrypted, signed mails with and without attachments.
> create SMIME (opaque and MIME) encrypted, signed mails with and without attachments.
> 
> cd messagecomposer && make test
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list