[Kde-pim] Review Request 112635: GID migration.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112635/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 3:55 p.m.)


Review request for KDEPIM.


Changes
-------

God dammit, one more of those an I'll never write another line of code without an automatic code formatter ;-)

Thanks for all the reviews =)


Description
-------

GID migration.

A new MigratorBase as interface for migrators.

I didn't adapt the existing KMigratorBase as it taylored towards one migrator per resource and I found a couple of other incompatibilities so I figured I rather make something clean from scratch.

It should be easy enough to adapt KMigratorBase to be based on top MigratorBase if we still need that code.


Diffs (updated)
-----

  migration/gid/gidmigrator.h PRE-CREATION 
  migration/gid/gidmigrationjob.cpp PRE-CREATION 
  migration/gid/gidmigrationjob.h PRE-CREATION 
  migration/gid/CMakeLists.txt PRE-CREATION 
  migration/CMakeLists.txt 3d15b97ab49a092e56416dce1c88725bcca3695e 
  migration/gid/gidmigrator.cpp PRE-CREATION 
  migration/gid/main.cpp PRE-CREATION 
  migration/infodialog.h 0003c48d3eab4260e4f0cc6a3ebf17ac762a1e1f 
  migration/infodialog.cpp 6f08db23922c181b98d809d77b98564f7b6a3ca8 
  migration/kmigratorbase.h 3a57917f0d0655320147ac13ef9544975c0188d0 
  migration/migratorbase.h PRE-CREATION 
  migration/migratorbase.cpp PRE-CREATION 
  migration/tests/CMakeLists.txt a9129a6bd033867345a668c2fdda0c3c0adae7d6 
  migration/tests/testgidmigration.h PRE-CREATION 
  migration/tests/testgidmigration.cpp PRE-CREATION 
  migration/tests/testmigratorbase.cpp PRE-CREATION 
  migration/tests/unittestenv/config.xml fa0eafe88d573518ad72269f1b8aafb7f93c885a 
  migration/tests/unittestenv/kdehome/share/config/akonadi_knut_resource_0rc PRE-CREATION 
  migration/tests/unittestenv/kdehome/share/config/kdebugrc 32317f7453f4c0a0ec778bd494ced8e7d65078f2 
  migration/tests/unittestenv/kdehome/testdata-res1.xml PRE-CREATION 
  plugins/akonadi_serializer_addressee.h e62da63afc93f32c5197426f565bc13db9f2ea72 
  plugins/akonadi_serializer_addressee.cpp 0c2d465248597660c2efb52335d2e479cca50c6f 
  plugins/tests/CMakeLists.txt 40017359428b06d8b9cba56b4c8d38eb8f92b069 
  plugins/tests/addresseeserializertest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112635/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/