[Kde-pim] Review Request 112724: Don't bother IMAP servers with not supported flags

[Kevin Ottens]

> On Sept. 23, 2013, 8:27 a.m., Kevin Ottens wrote:
> > resources/imap/resourcetask.cpp, line 351
> > <http://git.reviewboard.kde.org/r/112724/diff/1/?file=189524#file189524line351>
> >
> >     I'd keep the inserted logic in a separate method I think. To keep the symmetry with toAkonadiFlags... Also it's mixing two different level of abstractions with the added logic, a good enough argument for an extra method IMO.
> 
> André Wöbbeking wrote:
>     Do you mean that I should create a new method 
>     1) which each caller of fromAkonadiFlags() has to call afterwards? Sounds error prone.
>     2) which I call in fromAkonadiFlags()?
>     3) which a better name so that the caller sees that only supported flags are returned? That would be a simple rename otherwise it would be also error prone.

I suggest a method (that you probably would use instead of fromAkonadiFlags) which internally calls fromAkonadiFlags.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112724/#review40497
-----------------------------------------------------------


On Sept. 20, 2013, 1:13 p.m., André Wöbbeking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112724/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 1:13 p.m.)
> 
> 
> Review request for KDEPIM, Christian Mollekopf, Dan Vrátil, Kevin Ottens, Kevin Krammer, Laurent Montel, Sergio Luis Martins, and Volker Krause.
> 
> 
> Description
> -------
> 
> I moved the filtering from ChangeItemTask::triggerStoreJob() to ResourceTask::fromAkonadiFlags() which it is used always when IMAP flags are sent. I had to remove the static from fromAkonadiFlags() to be able to call collection().
> 
> I see one problem: it needs some time after the start of the imap resource til CollectionFlagsAttribute is set by RetrieveItemsTask. In that time the flags aren't filtered.
> 
> Are the permanent flags equal for all folders and could be stored in the resource?
> 
> 
> This addresses bugs 278082 and 291332.
>     http://bugs.kde.org/show_bug.cgi?id=278082
>     http://bugs.kde.org/show_bug.cgi?id=291332
> 
> 
> Diffs
> -----
> 
>   resources/imap/changeitemtask.cpp 1a5e969 
>   resources/imap/resourcetask.h 4a121fb 
>   resources/imap/resourcetask.cpp 30f93be 
> 
> Diff: http://git.reviewboard.kde.org/r/112724/diff/
> 
> 
> Testing
> -------
> 
> I don't get error messages about invalid parameters anymore.
> 
> 
> Thanks,
> 
> André Wöbbeking
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/