[Kde-pim] Review Request 112482: Use IMAP standard flags for replied messages

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112482/#review39941
-----------------------------------------------------------

Ship it!


Looks safe, thanks. 


- Dan Vrátil


On Sept. 12, 2013, 7:24 p.m., André Wöbbeking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112482/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 7:24 p.m.)
> 
> 
> Review request for KDEPIM, Christian Mollekopf, Dan Vrátil, Kevin Ottens, Kevin Krammer, Laurent Montel, and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> kmail2 uses it's own IMAP flags. Instead of RFC2060 compliant flags, like eg "\Answered", it uses "$REPLIED". That throws off other clients, e.g. Hastymail² webmailer which then cannot display the message status properly.
> 
> This is an alternative to #107179. I only change the IMAP resource. I convert the Akonadi flags to IMAP flags in ChangeItemsFlagsTask like it's done in ChangeItemTask and changed ResourceTask::fromAkonadiFlags() to handle Akonadi::MessageFlags::Replied.
> 
> 
> This addresses bug 291332.
>     http://bugs.kde.org/show_bug.cgi?id=291332
> 
> 
> Diffs
> -----
> 
>   resources/imap/resourcetask.cpp 599681c 
>   resources/imap/changeitemsflagstask.cpp f91d6e7 
> 
> Diff: http://git.reviewboard.kde.org/r/112482/diff/
> 
> 
> Testing
> -------
> 
> With this patch I don't get error messages when I reply to a mail.
> 
> 
> Thanks,
> 
> André Wöbbeking
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/