[Kde-pim] Review Request 112925: Async checking of fbobjects to validate url.

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112925/#review40735
-----------------------------------------------------------



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29964>

    style nitpick: spaces in parentheses



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29965>

    I am not sure, but I think the error text is potentially a user visible string



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29967>

    mabye use takeFirst() to ensure that the URL is not enqueued anymore?
    in the result slot you could then retrieve it from the job.
    



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29966>

    getJobFinished sounds a lot like a getter function.
    Maybe use a more "slot" like name, e.g. onGetJobFinished?



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29968>

    this uses fromLatin1()
    the next line suggests that mData is an ical entry, doesn't ical use UTF-8?



akonadi/calendar/freebusymanager.cpp
<http://git.reviewboard.kde.org/r/112925/#comment29969>

    hmm, if you don't need mData for anything other than this check, maybe use QByteArray::contains and avoid the conversion to QString?



akonadi/calendar/freebusymanager_p.h
<http://git.reviewboard.kde.org/r/112925/#comment29970>

    QObject *parent


- Kevin Krammer


On Sept. 25, 2013, 9:01 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112925/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 9:01 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Async checking of fbobjects to validate url.
> 
> This should keep korganizer from blocking when editing attendees, but apparently it doesnt.
> 
> static QString configFile() and const QString pref are unrelated changes (but I'll keep them in this patch anyways).
> 
> 
> This addresses bug 322278.
>     http://bugs.kde.org/show_bug.cgi?id=322278
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/freebusymanager.cpp 0cd4a441c3b18a3f8d6a6ead198c796195d71d62 
>   akonadi/calendar/freebusymanager_p.h 1f012d9e7226026ebc212bb0970d5beb0a67d534 
> 
> Diff: http://git.reviewboard.kde.org/r/112925/diff/
> 
> 
> Testing
> -------
> 
> Tried it.
> Failing to download freebusy no longer blocks korganizer.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/