[Kde-pim] Review Request 112523: c oding style for preprocessormanager.*

Dan Vrátil dvratil at redhat.com
Fri Sep 6 20:47:38 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112523/#review39501
-----------------------------------------------------------



server/src/preprocessormanager.h
<http://git.reviewboard.kde.org/r/112523/#comment29105>

    *dataStore



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29109>

    *PreprocessorManager::mSelf



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29106>

    Move this to the initialization section please



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29107>

    This too



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29108>

    ..and this one too



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29110>

    Remove the space after the star



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29111>

    *instance



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29112>

    *instance



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29113>

    *itemList



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29114>

    *nextPreprocessor



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29115>

    *dataStore



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29116>

    *preProcessor



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29117>

    *dataStore



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29118>

    *preProcessor



server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29119>

    *instance


- Dan Vrátil


On Sept. 6, 2013, 5:10 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112523/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 5:10 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   server/src/preprocessormanager.h 3c70bb6 
>   server/src/preprocessormanager.cpp 9f83cc6 
> 
> Diff: http://git.reviewboard.kde.org/r/112523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list