[Kde-pim] Review Request 112975: Set conforming string for postgreSQL

[Dan Vrátil]

> On Sept. 29, 2013, 5:27 p.m., Cédric  Villemain wrote:
> > server/src/storage/dbconfigpostgresql.cpp, line 283
> > <http://git.reviewboard.kde.org/r/112975/diff/3/?file=192961#file192961line283>
> >
> >     it is way better to try a 
> >     "stop -m immediate"
> >     before having to go to SIGABRT (and it works on windows too, while I'm unsure about 'kill')
> >
> 
> Dan Vrátil wrote:
>     Ok, please use "stop -m immediate" instead of kill.
>
> 
> Cédric  Villemain wrote:
>     I've some pending patch (not yet submited to review) for that. I prefer split the bugfix from the improvement if you agree.

Perfect.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112975/#review41000
-----------------------------------------------------------


On Sept. 28, 2013, 4:40 p.m., Cédric  Villemain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112975/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2013, 4:40 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> So the input/output are as expected.
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbconfigpostgresql.cpp acc65af149d0d4849dca535e9d0599e234befab2 
> 
> Diff: http://git.reviewboard.kde.org/r/112975/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cédric  Villemain
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/