[Kde-pim] Review Request 112761: Improve support for IMAP servers using separators other than "/"

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112761/#review40495
-----------------------------------------------------------


Unit test? :-)

Otherwise looks good.

- Kevin Ottens


On Sept. 16, 2013, 4:37 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112761/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 4:37 p.m.)
> 
> 
> Review request for KDEPIM, Andras Mantia and Kevin Ottens.
> 
> 
> Description
> -------
> 
> With this patch the IMAP resource will detect what separator does the server use by extracting it from KIMAP::ListJob reply during the first collection sync which happens every time the resource is started. The separator is then stored, so that any subsequent call to ResourceState::separatorCharacter() will use the stored separator instead of guessing it every time.
> 
> In case ResourceState::separatorCharacter() is called before the separator is detected separatorCharacter() will fallback to it's old behaviour and will try to guest the separator (could theoretically happen when there are changes pending in ChangeRecorder before the start - the collection sync will be dispatched after all the changes from ChangeRecorder are replayed). This fallback path incorporates the improved detection code from https://git.reviewboard.kde.org/r/112734/.
> 
> 
> Diffs
> -----
> 
>   resources/imap/resourcestateinterface.h d89157f 
>   resources/imap/resourcestate.h b1c3eed 
>   resources/imap/resourcestate.cpp cd88fd2 
>   resources/imap/imapresource.cpp 3f2dda7 
>   resources/imap/imapresource.h 56e47b9 
>   resources/imap/resourcetask.h 0a77097 
>   resources/imap/resourcetask.cpp f63e986 
>   resources/imap/retrievecollectionstask.cpp 51ab703 
>   resources/imap/tests/dummyresourcestate.h c039a82 
>   resources/imap/tests/dummyresourcestate.cpp 0da6a9d 
> 
> Diff: http://git.reviewboard.kde.org/r/112761/diff/
> 
> 
> Testing
> -------
> 
> Successfully created, renamed and deleted a collection on an IMAP server that uses "." as folder separators. In all cases the remoteId of the collection was correctly prefixed with ".". On a server that is using "/" the behaviour was correct as well.
> 
> Also verified there is no regression for the fix mentioned by Andras in https://git.reviewboard.kde.org/r/112734/
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/