[Kde-pim] Review Request 112408: coding style for akonadiconnection.*

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112408/#review39095
-----------------------------------------------------------


I'm sorry, I missed a few things in my first review.


server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28835>

    One more thing I wanted to do for a while now and this  is a good opportunity to do it: could you add #define AKONADI_PROTOCOL_VERSION 34 to the top of this file (not into protocol_p.h) and use the macro here?
    
    It will make bumping protocol versions bit easier.



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28837>

    Fix position of the star and "&" please



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28838>

    Add spaces inside () please



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28840>

    Here too



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28841>

    And here...



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28842>

    ...here...



server/src/akonadiconnection.cpp
<http://git.reviewboard.kde.org/r/112408/#comment28843>

    ...and here :-)


- Dan Vrátil


On Sept. 1, 2013, 6:02 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112408/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2013, 6:02 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   server/src/akonadiconnection.h e9f26fe 
>   server/src/akonadiconnection.cpp d67e3ca 
> 
> Diff: http://git.reviewboard.kde.org/r/112408/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/