[Kde-pim] Review Request 112794: Don't notify clients about GID-only changes

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112794/#review40279
-----------------------------------------------------------


It's not really what I meant but I guess that works too ;-)

It could be a bit magic behaviour to skip notifications in that special case (it's not what you would normally expect, is it?), that's why I suggested that resources should rather just ignore GID changes than the notifications not being emitted, but if you feel confident about it I'm fine with it.

- Christian Mollekopf


On Sept. 18, 2013, 3:19 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112794/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 3:19 p.m.)
> 
> 
> Review request for Akonadi.
> 
> 
> Description
> -------
> 
> Store GID in database, but don't send out notification.
> 
> This obsoletes both STORE SILENT reviews :)
> 
> 
> Diffs
> -----
> 
>   server/src/handler/store.cpp b87cfe3 
> 
> Diff: http://git.reviewboard.kde.org/r/112794/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/