[Kde-pim] Review Request 112801: contact editor: make label buddy shortcuts work for all fields

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112801/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 10:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Description
-------

Although most of the field labels in the contact editor have buddy widgets set (to the appropriate entry field) and show an Alt+letter shortcut, some of them do not work when that is pressed because the custom widgets do not have a focus proxy/policy.  This change corrects that for the pages and fields:

Contact: Name, Display, Email, Messaging

Business: Free/Busy

Personal: Birthdate, Anniversary

Location: Address combo

For the address type combo in the "Location" tab, and the same combo in the address edit dialogue, a label is placed before it so that it can have an accelerator to focus the combo box.  Screen shots are attached.

With these changes (plus 33ec1c35 to kdepimlibs and 7964a6d1 to kdepim for the "Crypto settings" plugin) , all contact editor fields can be activated or given focus using Alt+letter shortcuts.  Well, apart from "Office" under "Business", where there are no available accelerators to be assigned :-(


Diffs
-----

  akonadi/contact/editor/addresseditwidget.cpp ead62a5 
  akonadi/contact/editor/dateeditwidget.cpp 0056154 
  akonadi/contact/editor/displaynameeditwidget.cpp 6bd0b43 
  akonadi/contact/editor/emaileditwidget.cpp d1e30ba 
  akonadi/contact/editor/freebusyeditwidget.cpp 5ae27a5 
  akonadi/contact/editor/imeditwidget.cpp cda7895 
  akonadi/contact/editor/nameeditwidget.cpp 9d6dd50 

Diff: http://git.reviewboard.kde.org/r/112801/diff/


Testing
-------

Build kdepimlibs with these changes.  Checked action of all underlined accelerators in kaddressbook contact editor dialogue.


File Attachments
----------------

Contact editor "Location" tab
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/18/kaddressbook-editor-buddies_1.png
Address edit dialogue
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/18/kaddressbook-editor-buddies_2.png


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/