[Kde-pim] Review Request 112945: Refactor MessageComposer::Util::composeHeadersAndBody

[Laurent Montel]

> On Sept. 26, 2013, 5:16 a.m., Laurent Montel wrote:
> > messagecomposer/utils/util.cpp, line 78
> > <http://git.reviewboard.kde.org/r/112945/diff/1/?file=192719#file192719line78>
> >
> >     I prefer if (exact condition) {... } else {...} as previous
> >     just need to reverse code no a big deal I think.
> 
> Sandro Knauß wrote:
>     I don't understand, what you mean with exact condition. Do you mean:
>     if ( (!sign && (format &  Kleo::AnySMIME)) || format & Kleo::SMIMEOpaqueFormat ) {...} else {...}

You change if ( makeMultiMine ) { } else {...} to if ( !makeMultiMine ) { } else {...}
me I prefere if ( makeMultiMine ) { } else {...}
Check positive condition and after else.
Regards


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112945/#review40842
-----------------------------------------------------------


On Sept. 25, 2013, 8:41 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112945/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 8:41 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Refactor MessageComposer::Util::composeHeadersAndBody
> 
> * easier to read, what is going on for different crypto protos.
> * Made sure all crypto test are still valid.
> 
> using function setBodyAndCTE to shorten MessageComposer::Util::composeHeadersAndBody
> 
> 
> Diffs
> -----
> 
>   messagecomposer/utils/util.cpp 13765632a24cacccb3356f985a77ef26530d02bf 
> 
> Diff: http://git.reviewboard.kde.org/r/112945/diff/
> 
> 
> Testing
> -------
> 
> run messagecomposer/tests/cryptocomposertest.shell
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/