[Kde-pim] Review Request 112770: Disable postgres and sqlite backends for calendaring unit-tests

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112770/#review40212
-----------------------------------------------------------



akonadi/AkonadiMacros.cmake
<http://git.reviewboard.kde.org/r/112770/#comment29715>

    Use positive variable names - if (KDEPIMLIBS_RUN_MYSQL_FS_ISLOATED_TESTS) {...}
    
    You can also move the MySQL detection into that "if" - no point detecting MySQL if we are not going to test against it.
    
    Same for postgresql and SQLite



akonadi/calendar/tests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112770/#comment29714>

    It makes no sense to disable all, I'd keep at least SQLite enabled by default.


- Dan Vrátil


On Sept. 17, 2013, 2:12 p.m., Sergio Luis Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112770/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 2:12 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Description
> -------
> 
> It's very slow to run these and it's not the calendar's job to test if postgres is working fine.
> 
> 
> Diffs
> -----
> 
>   akonadi/AkonadiMacros.cmake 59574cf 
>   akonadi/calendar/tests/CMakeLists.txt 7771761 
> 
> Diff: http://git.reviewboard.kde.org/r/112770/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Luis Martins
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/