[Kde-pim] Review Request 112961: introduce more tests

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112961/#review40883
-----------------------------------------------------------


Good idea, but this looks a lot like something that would benefit from a data driven test
http://techbase.kde.org/Development/Tutorials/Unittests#Tutorial_2:_Data_driven_testing_of_a_date_class


libs/tests/notificationmessagetest.h
<http://git.reviewboard.kde.org/r/112961/#comment30039>

    better call it
    testToString()
    



libs/tests/notificationmessagetest.cpp
<http://git.reviewboard.kde.org/r/112961/#comment30036>

    remove



libs/tests/notificationmessagetest.cpp
<http://git.reviewboard.kde.org/r/112961/#comment30037>

    space before closing parentheses



libs/tests/notificationmessagetest.cpp
<http://git.reviewboard.kde.org/r/112961/#comment30038>

    same here
    also if you don't need toInvalidType as a variable later on, just
    QCOMPARE( msg.toString(), ... )


- Kevin Krammer


On Sept. 26, 2013, 4:05 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112961/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2013, 4:05 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> I would like to introduce some more tests for akonadi.
> What do you think about this way?
> 
> 
> Diffs
> -----
> 
>   libs/notificationmessage.cpp 7392c0a 
>   libs/tests/notificationmessagetest.h 6d8e990 
>   libs/tests/notificationmessagetest.cpp 3a18e44 
> 
> Diff: http://git.reviewboard.kde.org/r/112961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/