[Kde-pim] Review Request 112724: Don't bother IMAP servers with not supported flags

[André Wöbbeking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112724/
-----------------------------------------------------------

(Updated Sept. 14, 2013, 5:06 p.m.)


Review request for KDEPIM, Christian Mollekopf, Dan Vrátil, Kevin Ottens, Kevin Krammer, Laurent Montel, Sergio Luis Martins, and Volker Krause.


Changes
-------

Removed bug 323762.


Description
-------

I moved the filtering from ChangeItemTask::triggerStoreJob() to ResourceTask::fromAkonadiFlags() which it is used always when IMAP flags are sent. I had to remove the static from fromAkonadiFlags() to be able to call collection().

I see one problem: it needs some time after the start of the imap resource til CollectionFlagsAttribute is set by RetrieveItemsTask. In that time the flags aren't filtered.


This addresses bugs 278082 and 291332.
    http://bugs.kde.org/show_bug.cgi?id=278082
    http://bugs.kde.org/show_bug.cgi?id=291332


Diffs
-----

  resources/imap/changeitemtask.cpp 1a5e969 
  resources/imap/resourcetask.h 4a121fb 
  resources/imap/resourcetask.cpp 30f93be 

Diff: http://git.reviewboard.kde.org/r/112724/diff/


Testing
-------

I don't get error messages about invalid parameters anymore.


Thanks,

André Wöbbeking

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/