[Kde-pim] Review Request 112920: [Patch] Wrap words properly when printing a calendar in KOrganizer

[Damian Hofmann]

> On Sept. 24, 2013, 8:58 p.m., Sergio Luis Martins wrote:
> > Thanks!
> > 
> > If you plan on fixing more stuff we can get you a commit account.

Thank you for your quick reply. There are indeed a few other bugs in kdepim that bother me and that I wanted to look into.
I'm not sure how much time I can spare for this in the near future, so I can't guarantee much, aside from small bugfixes from time to time. However, if this is not a problem, I'd be glad to have commit access as that would indeed make things easier for me.


- Damian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112920/#review40724
-----------------------------------------------------------


On Sept. 24, 2013, 9:09 p.m., Damian Hofmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112920/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 9:09 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This change enables word-wrapping for the text in the event boxes when printing a calendar in KOrganizer. Before, line breaks could occur anywhere, which made the resulting prints look rather ugly (see the attached picture for comparison). This fixes Bug 203235.
> 
> I tried using KWordWrap for this, however since it sometimes removes line breaks from the input string when inserting others nearby, this messed up the formating when printing events with description (which is always preceded by a line break).
> 
> [I have no commit access, so someone else will have to commit this if it is accepted.]
> 
> 
> This addresses bug 203235.
>     http://bugs.kde.org/show_bug.cgi?id=203235
> 
> 
> Diffs
> -----
> 
>   korganizer/printing/calprintpluginbase.cpp f27fec180e8861e4d8a237b65c7837deaabf0313 
> 
> Diff: http://git.reviewboard.kde.org/r/112920/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Printed events before and after the change
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/24/BeforeAfter.png
> 
> 
> Thanks,
> 
> Damian Hofmann
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/