[Kde-pim] Review Request 112523: c oding style for preprocessormanager.*
Kevin Krammer
krammer at kde.org
Wed Sep 4 18:41:48 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112523/#review39367
-----------------------------------------------------------
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29004>
space before last )
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29005>
since you are repositioning * elsewhere, *instance
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29006>
I am not sure but I think the debug stream already wraps strings in whitespaces
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29007>
see above
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29008>
see above
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29009>
see above
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29010>
*waitQueue
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29011>
*dataStore
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29012>
*dataStore
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29013>
*waitQueue
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29014>
*dataStore
server/src/preprocessormanager.cpp
<http://git.reviewboard.kde.org/r/112523/#comment29015>
*nextPreprocessor
- Kevin Krammer
On Sept. 4, 2013, 4:46 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112523/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 4:46 p.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
>
>
> Description
> -------
>
> next job
>
>
> Diffs
> -----
>
> server/src/preprocessormanager.h 3c70bb6
> server/src/preprocessormanager.cpp 9f83cc6
>
> Diff: http://git.reviewboard.kde.org/r/112523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list