[Kde-pim] Review Request 112920: [Patch] Wrap words properly when printing a calendar in KOrganizer

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112920/#review40725
-----------------------------------------------------------


This review has been submitted with commit 00a614fe7aa27ce2a3e4ba2e3da4766356a77b4a by Sergio Martins on behalf of Damian Hofmann to branch KDE/4.11.

- Commit Hook


On Sept. 24, 2013, 7:59 p.m., Damian Hofmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112920/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:59 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This change enables word-wrapping for the text in the event boxes when printing a calendar in KOrganizer. Before, line breaks could occur anywhere, which made the resulting prints look rather ugly (see the attached picture for comparison). This fixes Bug 203235.
> 
> I tried using KWordWrap for this, however since it sometimes removes line breaks from the input string when inserting others nearby, this messed up the formating when printing events with description (which is always preceded by a line break).
> 
> [I have no commit access, so someone else will have to commit this if it is accepted.]
> 
> 
> This addresses bug 203235.
>     http://bugs.kde.org/show_bug.cgi?id=203235
> 
> 
> Diffs
> -----
> 
>   korganizer/printing/calprintpluginbase.cpp f27fec180e8861e4d8a237b65c7837deaabf0313 
> 
> Diff: http://git.reviewboard.kde.org/r/112920/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Printed events before and after the change
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/24/BeforeAfter.png
> 
> 
> Thanks,
> 
> Damian Hofmann
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/