[Kde-pim] Review Request 112925: Async checking of fbobjects to validate url.

[Christian Mollekopf]

> On Sept. 25, 2013, 9:20 a.m., Kevin Krammer wrote:
> > akonadi/calendar/freebusymanager.cpp, line 99
> > <http://git.reviewboard.kde.org/r/112925/diff/1/?file=192130#file192130line99>
> >
> >     I am not sure, but I think the error text is potentially a user visible string

The error state is only internally used to indicate that non of the freebusy urls is valid. I changed it to a debug string.


> On Sept. 25, 2013, 9:20 a.m., Kevin Krammer wrote:
> > akonadi/calendar/freebusymanager.cpp, line 103
> > <http://git.reviewboard.kde.org/r/112925/diff/1/?file=192130#file192130line103>
> >
> >     mabye use takeFirst() to ensure that the URL is not enqueued anymore?
> >     in the result slot you could then retrieve it from the job.
> >

Didn't realize I can just retrieve it from the job again. That's better now.


> On Sept. 25, 2013, 9:20 a.m., Kevin Krammer wrote:
> > akonadi/calendar/freebusymanager.cpp, line 119
> > <http://git.reviewboard.kde.org/r/112925/diff/1/?file=192130#file192130line119>
> >
> >     this uses fromLatin1()
> >     the next line suggests that mData is an ical entry, doesn't ical use UTF-8?

Yes it is, and yes it does =) I don't think it matter for the string we're interested in so I just use QByteArray::contains (I simply copied the logic from the previous function before).


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112925/#review40735
-----------------------------------------------------------


On Sept. 25, 2013, 9:01 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112925/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 9:01 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Async checking of fbobjects to validate url.
> 
> This should keep korganizer from blocking when editing attendees, but apparently it doesnt.
> 
> static QString configFile() and const QString pref are unrelated changes (but I'll keep them in this patch anyways).
> 
> 
> This addresses bug 322278.
>     http://bugs.kde.org/show_bug.cgi?id=322278
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/freebusymanager.cpp 0cd4a441c3b18a3f8d6a6ead198c796195d71d62 
>   akonadi/calendar/freebusymanager_p.h 1f012d9e7226026ebc212bb0970d5beb0a67d534 
> 
> Diff: http://git.reviewboard.kde.org/r/112925/diff/
> 
> 
> Testing
> -------
> 
> Tried it.
> Failing to download freebusy no longer blocks korganizer.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/