[Kde-pim] Review Request 112617: coding style for imapstreamparsertest
Dan Vrátil
dvratil at redhat.com
Mon Sep 9 18:48:24 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112617/#review39668
-----------------------------------------------------------
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29214>
Remove the spaces between ()
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29215>
Here too
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29218>
Remove the space here too
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29219>
Missing spaces between the closing parentheses
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29220>
Here too
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29216>
Indent content of the entire try {} block by one tab please
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29222>
Remove the space between () please
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29221>
See above
server/tests/unittest/imapstreamparsertest.cpp
<http://git.reviewboard.kde.org/r/112617/#comment29217>
Add {}
- Dan Vrátil
On Sept. 9, 2013, 7:10 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112617/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 7:10 p.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
>
>
> Description
> -------
>
> next job for akonadi/server/tests/unittest
>
>
> Diffs
> -----
>
> server/tests/unittest/imapstreamparsertest.h ae111bd
> server/tests/unittest/imapstreamparsertest.cpp 405e5e1
>
> Diff: http://git.reviewboard.kde.org/r/112617/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list