[Kde-pim] Review Request 112523: c oding style for preprocessormanager.*

[Guy Maurel]

> On Sept. 4, 2013, 5:41 p.m., Kevin Krammer wrote:
> > server/src/preprocessormanager.cpp, line 129
> > <http://git.reviewboard.kde.org/r/112523/diff/1/?file=187025#file187025line129>
> >
> >     since you are repositioning * elsewhere, *instance

these are difficult to automatically find.
Thanks for helping


> On Sept. 4, 2013, 5:41 p.m., Kevin Krammer wrote:
> > server/src/preprocessormanager.cpp, line 143
> > <http://git.reviewboard.kde.org/r/112523/diff/1/?file=187025#file187025line143>
> >
> >     I am not sure but I think the debug stream already wraps strings in whitespaces

you are right. It is a false interpretation I do.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112523/#review39367
-----------------------------------------------------------


On Sept. 5, 2013, 4:24 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112523/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 4:24 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Description
> -------
> 
> next job
> 
> 
> Diffs
> -----
> 
>   server/src/preprocessormanager.h 3c70bb6 
>   server/src/preprocessormanager.cpp 9f83cc6 
> 
> Diff: http://git.reviewboard.kde.org/r/112523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/