[Kde-pim] Review Request 108837: kaddressbook: display and make clickable all IM addresses

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108837/
-----------------------------------------------------------

(Updated Oct. 10, 2013, 3:29 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Currently the address book only displays the "set as standard" IM address, even if the contact has more than one, and it is not clickable so nothing can be done with the displayed information

This change displays all of the configured IM addresses, identifying the protocol/application that applies - see screen shot.  Clicking on the address or icon will emit a new signal messagingClicked() from the contact viewer, similar to the existing ones (urlClicked() etc), identifying the protocol and address.  With this in place in kdepimlibs, a configuration and GUI could be implemented in the application to start an IM program, run a command or do whatever else is appropriate.

This addition is BC (adding a new non-virtual function).


Diffs
-----

  akonadi/contact/contactviewer.h 2ef8802 
  akonadi/contact/contactviewer.cpp 06fda94 
  akonadi/contact/standardcontactformatter.cpp 7e28346 

Diff: http://git.reviewboard.kde.org/r/108837/diff/


Testing
-------

Built kdepimlibs and kaddressbook with this change.  Checked display of multiple IM addresses and that the signal is emitted when one is clicked.


File Attachments
----------------

IM addresses display
  http://git.reviewboard.kde.org/media/uploaded/files/2013/02/07/kaddressbook-imdisplay.png


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/