[Kde-pim] Review Request 113221: FindQGpgme: Be more silent when looking for Gpgme.
Allen Winter
winter at kde.org
Sun Oct 13 00:09:18 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113221/#review41619
-----------------------------------------------------------
Ship it!
I agree with this for sure in a FindFoo.cmake
- Allen Winter
On Oct. 12, 2013, 6:46 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113221/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2013, 6:46 p.m.)
>
>
> Review request for KDEPIM-Libraries.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> FindQGpgme: Be more silent when looking for Gpgme.
>
> The fact that FindQGpgme looks for Gpgme itself should be transparent to
> users. Additionally, if QUIET is not passed to the find_package() call CMake
> will output duplicate messages if the user also calls find_package(Gpgme).
>
>
> Diffs
> -----
>
> cmake/modules/FindQGpgme.cmake 0355ebe2b095b3d1204b6dde91f1016a6e62c225
>
> Diff: http://git.reviewboard.kde.org/r/113221/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list