[Kde-pim] Review Request 113171: Update KPIMUtils email address validator to pass tests

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113171/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 1:47 p.m.)


Status
------

This change has been discarded.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

1) Remove FIXME: double quotes are handled in the main loop below
2) Don't bail out when dot count is zero: 
     1) user at localhost is a valid address without any dot (right?)
     2) in case of mailto:@mydomain we want to fail on InvalidCharacter rather then TooFewDots (we get that eventually at the end of the validation)
3) Don't fail when dot is at the end of address: "user at domain.com." - domains ending with dot are valid FQDNs
4) Update tooManyAtsFlag in AngleAddress context too


Diffs
-----

  kpimutils/email.cpp 925d100 

Diff: http://git.reviewboard.kde.org/r/113171/diff/


Testing
-------

All tests pass now (assuming they are correct :D)


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/