[Kde-pim] Review Request 112938: after all the hints I get, this is a second run, part one

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112938/#review40783
-----------------------------------------------------------


Finally had a lecture boring enough to start reviewing this :-) 


libs/notificationmessage.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30146>

    Move commas to the beginning of lines please



libs/notificationmessage.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30150>

    Spaces inside the first "*(...)"



libs/notificationmessage.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30151>

    Spaces inside the outter "*(...)"



libs/notificationmessage.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30147>

    Add spaces around () in expressions please



libs/notificationmessagev2.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30148>

    Move the commas to the beginning of the lines please



libs/notificationmessagev2.cpp
<http://git.reviewboard.kde.org/r/112938/#comment30149>

    Missing {}



libs/notificationmessagev2_p.h
<http://git.reviewboard.kde.org/r/112938/#comment29989>

    Put ":" on next line please


- Dan Vrátil


On Sept. 25, 2013, 7:02 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112938/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 7:02 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> to complete the job
> 
> 
> Diffs
> -----
> 
>   agentserver/agentserver.cpp 59c19fd 
>   libs/imapparser.cpp 134b984 
>   libs/imapset.cpp 001b9cb 
>   libs/notificationmessage.cpp 7392c0a 
>   libs/notificationmessage_p.h cb42827 
>   libs/notificationmessagev2.cpp 4cad2ff 
>   libs/notificationmessagev2_p.h 62ba464 
>   libs/xdgbasedirs.cpp acc316b 
>   libs/xdgbasedirs_p.h a7fa096 
> 
> Diff: http://git.reviewboard.kde.org/r/112938/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/