[Kde-pim] Review Request 113172: kaddressbook: show age in years alongside birthday

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113172/#review41394
-----------------------------------------------------------



kaddressbook/viewertemplates/contact_embedded.html
<http://git.reviewboard.kde.org/r/113172/#comment30291>

    possible to reduce it to ? :
    
    {% if .... }
       {% with.... contact.birthdayage}
    {% else...}
       {% with contact.birthday...}
    {%endif}
    { % include... }
    {%endwith %}
    
    not tested but better to reduce code if possible.


- Laurent Montel


On Oct. 8, 2013, 1:16 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113172/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 1:16 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The standard HTML contact formatter used to show the age in years alongside the birthday, in the format "19th January 1973 (40 years old)".
> 
> This change reintroduces that as the default for the standard Grantlee-based templates.  The existing "age" is still the age in whole years, the new "birthdayage" is the birthday plus age string formatted as above.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/viewertemplates/contact_embedded.html e76a5b5 
>   kaddressbookgrantlee/formatter/grantleecontactformatter.cpp 8aec366 
> 
> Diff: http://git.reviewboard.kde.org/r/113172/diff/
> 
> 
> Testing
> -------
> 
> Built kaddressbook with these changes, checked display of contacts with and without birthdays.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/