[Kde-pim] Review Request 112786: Close IMAP mailbox before deleting it

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112786/
-----------------------------------------------------------

(Updated Oct. 14, 2013, 4:39 p.m.)


Review request for KDEPIM and Kevin Ottens.


Changes
-------

Right, few more years and I'll remember to update tests every time ;-)


Anyway, I had to refactor the code a bit, the original approach of enqueueing all the jobs on the session did not work anymore, because the DeleteJob was enqueued after all other jobs instead of right after it's related CloseJob


Bugs: 324932
    http://bugs.kde.org/show_bug.cgi?id=324932


Repository: kdepim-runtime


Description
-------

Some IMAP servers don't allow deleting a currently SELECTed mailbox, so we close it before DELETEing it (see the referenced bug).

I haven't found any such restriction in RFC, but we all know that reality does not always follow RFCs :-)


Diffs (updated)
-----

  resources/imap/removecollectionrecursivetask.h b42c4e6 
  resources/imap/removecollectionrecursivetask.cpp aa74a73 
  resources/imap/removecollectiontask.h 48335d3 
  resources/imap/removecollectiontask.cpp b258fb1 
  resources/imap/tests/testremovecollectiontask.cpp 56bcaab 

Diff: http://git.reviewboard.kde.org/r/112786/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/