[Kde-pim] Review Request 113069: fix rendertests

[Sandro Knauß]

> On Oct. 3, 2013, 5:18 a.m., Laurent Montel wrote:
> > As you explain in your mail in kdepim-devel it's not possible to reactive it because it depends of config
> > So for example for me it doesn't work.
> > So I am against this patch.
> > Regards
> 
> Volker Krause wrote:
>     Yep, this is not fixing the actual problem. I think there's value in these tests though, can't we set a well-defined palette and font configuration for the test? Either on the C++ side (need to check where we actually get those values from), or by changing the config files (unit tests use a dedicated .kde folder, so this can be done safely).

All colors are come from the cssHelper defined in rendertests.cpp l.85. Is there a way to define all colors "by hand" for the tests (actually all values are protected (messageviewer/viewer/csshelperbase.h)? At first I thought, that I can just reuse code from messageviewer/tests/viewer_gui, but they use a viewer object that has the method setHeaderStyleAndStrategy (messageviewer/viewer/viewer.h). And I don't understand the way how setHeaderStyleAndStrategy works.

To make it short: I'm not that familiar in all the style foo so any help from your side is very welcomed.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113069/#review41152
-----------------------------------------------------------


On Oct. 2, 2013, 9:17 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113069/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 9:17 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> update rendertests to run again successfully.
> 
> 
> Diffs
> -----
> 
>   messageviewer/tests/data/forward-openpgp-signed-encrypted.mbox.html d16473a8717c004b94842b319dd90db654c2d7ab 
>   messageviewer/tests/data/encapsulated-with-attachment.mbox.html c4fe631fae93ed908758bf12aa970fa903b68964 
>   messageviewer/tests/data/html.mbox.html 407cce9587d9fe32a85036773e72ad36b7bfe65d 
>   messageviewer/tests/data/htmlonly.mbox.html c76708844cb728f77079afb8e8d0c2d8a762fb69 
>   messageviewer/tests/data/inlinepgpencrypted-appendix.mbox.html 1766a2986ab2b40e4ac949b3e9c7086aa37d75d7 
>   messageviewer/tests/data/inlinepgpencrypted.mbox.html c96bf1eef7c59ad9bc8d4c39333b58b168a6b895 
>   messageviewer/tests/data/no-content-type.mbox.html 00fb8c9da4ee20d21a0eee39a13ec8a619f9f183 
>   messageviewer/tests/data/openpgp-encrypted.mbox.html cfbed89961bb4b81c54a2e4546b4930c2cd6214f 
>   messageviewer/tests/data/openpgp-signed-encrypted.mbox.html 9080b4f9f937aaeaed3d832c9a4a3e4591e05daa 
>   messageviewer/tests/data/openpgp-signed-mailinglist.mbox.html 9990ee7c1bcc44922a2f1399e9448f0baf2c2ae4 
>   messageviewer/tests/data/signed-forward-openpgp-signed-encrypted.mbox.html a33a9b2d0ee98fba954003a01aa873acf068f611 
>   messageviewer/tests/data/smime-encrypted-octet-stream.mbox.html 77c42f5dcc2128c367ef20c1e49343c82bcdc7d4 
>   messageviewer/tests/data/smime-encrypted.mbox.html 77c42f5dcc2128c367ef20c1e49343c82bcdc7d4 
>   messageviewer/tests/data/smime-signed-encrypted.mbox.html 31497cc81f0f6595e8db24c69e6dbc67e84c2e7a 
>   messageviewer/tests/data/text+html-maillinglist.mbox.html 873cec80eb24b1a8f81feccae69fcdbc4ecb5c7a 
>   messageviewer/tests/data/tnef-one-file.mbox.html 62fb9cd105ec38dfba7dae9bffe1d50801232f9a 
>   messageviewer/tests/data/tnef-two-files.mbox.html d22bd6096a8cc2335b6673d4c9c57f9295b6c685 
>   messageviewer/tests/rendertest.cpp 9f151145b4dffdf746a60cf2c01064a3638686b2 
> 
> Diff: http://git.reviewboard.kde.org/r/113069/diff/
> 
> 
> Testing
> -------
> 
> messageviewer/tests/rendertest.shell
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/