[Kde-pim] Review Request 113283: coding style for dbconfigmysql-2

[Guy Maurel]

> On Oct. 16, 2013, 6:54 p.m., Kevin Krammer wrote:
> > server/src/storage/dbconfigmysql.cpp, line 128
> > <http://git.reviewboard.kde.org/r/113283/diff/1/?file=202219#file202219line128>
> >
> >     I'd say we add spaced here between ( and mServerPath and the )) at the end

Why?
It is exactly the question I asked 2013-10-15 about:
  "() surrounding expression"

I think, we should diskuss this in Brno.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113283/#review41829
-----------------------------------------------------------


On Oct. 16, 2013, 6:34 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113283/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 6:34 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> next job for akonadi/server/src/storage/
> 
> 
> Diffs
> -----
> 
>   server/src/storage/dbconfigmysql.h 1537336 
>   server/src/storage/dbconfigmysql.cpp f55b76b 
> 
> Diff: http://git.reviewboard.kde.org/r/113283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/