[Kde-pim] Review Request 112941: after all the hints I get, this is a second run, part 2

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112941/#review41070
-----------------------------------------------------------


I think we should leave the sqlite driver intact. The code is a 3rd-party code imported from Qt with some additional patches. Changing the coding style would make applying future patches, or rebasing the current patches on newer upstream code more difficult.


rds/bridgeconnection.cpp
<http://git.reviewboard.kde.org/r/112941/#comment30152>

    Please add space after (struct sockaddr*) and remove the space after sizeof() - we use it as a method instead of operator


- Dan Vrátil


On Sept. 25, 2013, 7:22 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112941/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2013, 7:22 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> to complete the job
> 
> 
> Diffs
> -----
> 
>   qsqlite/src/qsql_sqlite.h fcf9157 
>   qsqlite/src/qsql_sqlite.cpp c1e9508 
>   rds/bridgeconnection.cpp ee31ed1 
>   rds/main.cpp d608a93 
> 
> Diff: http://git.reviewboard.kde.org/r/112941/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/