[Kde-pim] Review Request 112786: Close IMAP mailbox before deleting it

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112786/#review41437
-----------------------------------------------------------



resources/imap/removecollectionrecursivetask.cpp
<http://git.reviewboard.kde.org/r/112786/#comment30314>

    Hmmm... makes me wonder about the error case. If CloseJob fails we'll run the DeleteJob still, we likely don't want to as something would be fishy.



resources/imap/resourcestateinterface.cpp
<http://git.reviewboard.kde.org/r/112786/#comment30313>

    Unrelated change


- Kevin Ottens


On Sept. 24, 2013, 5:16 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112786/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 5:16 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Bugs: 324932
>     http://bugs.kde.org/show_bug.cgi?id=324932
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Some IMAP servers don't allow deleting a currently SELECTed mailbox, so we close it before DELETEing it (see the referenced bug).
> 
> I haven't found any such restriction in RFC, but we all know that reality does not always follow RFCs :-)
> 
> 
> Diffs
> -----
> 
>   resources/imap/removecollectionrecursivetask.cpp aa74a73 
>   resources/imap/removecollectiontask.h 48335d3 
>   resources/imap/removecollectiontask.cpp b258fb1 
>   resources/imap/resourcestateinterface.cpp 4784668 
>   resources/imap/tests/testremovecollectiontask.cpp 56bcaab 
> 
> Diff: http://git.reviewboard.kde.org/r/112786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/