[Kde-pim] Review Request 113348: use gpgme instead of kpgp for decrypting OpenPGP Inline messages

Commit Hook null at kde.org
Wed Oct 30 00:21:16 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113348/#review42678
-----------------------------------------------------------


This review has been submitted with commit 25f0b41941e093071cf9cee624b24f30a71047a1 by Sandro Knauß to branch master.

- Commit Hook


On Oct. 21, 2013, 4:30 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113348/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 4:30 p.m.)
> 
> 
> Review request for KDEPIM and Ondrej Holecek.
> 
> 
> Bugs: 247657, 291890 and 295217
>     http://bugs.kde.org/show_bug.cgi?id=247657
>     http://bugs.kde.org/show_bug.cgi?id=291890
>     http://bugs.kde.org/show_bug.cgi?id=295217
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> * use gpgme instead of kpgp for decrypting PGP Inline messages
> * Added chaset iso15 test with correct signature
> * prepare tests for kpgp->gpgme for inline messages.
> * How can I enable the async function for VerifyOpaqueBodyPartMemento l.3029 ? Is there a way to test this async behaviour?
> 
> This patch replaces #113074. #113074 is only a workaround for the general problem, when using kpgp for en-/decrypting. This own get rid of kpgp for decrypting messages.
> 
> 
> Diffs
> -----
> 
>   messagecomposer/tests/cryptofunctions.cpp 2bdf106fad4343becdae93284b23c85ae52101fd 
>   messageviewer/tests/data/openpgp-inline-charset-encrypted.mbox PRE-CREATION 
>   messageviewer/tests/data/openpgp-inline-charset-encrypted.mbox.html PRE-CREATION 
>   messageviewer/tests/objecttreeparsertest.cpp da45e664edd084d0f49fd33194a5a8ede373e318 
>   messageviewer/tests/rendertest.cpp 0ca4fa9e4db26e41e962c909f381c6c342a983d5 
>   messageviewer/viewer/objecttreeparser.cpp 5ce05995e2725325d8ae62d903a4af0dbc059697 
>   templateparser/tests/templateparsertest.cpp bb987cca87d1c356c1077d0c2a52c596921905c9 
> 
> Diff: http://git.reviewboard.kde.org/r/113348/diff/
> 
> 
> Testing
> -------
> 
> run messageviewer/rendertest.shell
> run messagecomposer/cryptocomposertest.shell
> run templateparser/templateparsertest.shell
> test with own crypted/signed messages
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list