[Kde-pim] Review Request 113010: KIMAP::FetchJob: Introduce a new scope to fetch all headers

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113010/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 11:31 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Kevin Ottens.


Repository: kdepimlibs


Description
-------

wilder on IRC has tracked down a problem with filters not working sometimes on IMAP: the problem is that when not using the disconnected mode, the IMAP resource fetches only a very limited subset of mail headers: To, From, Message-Id, References, In-Reply-To, Subject and Date. This means that if you want to have a mailing-list filter based on List-Id header, the filter simply won't work.

This patch adds a new "FullHeaders" scope to KIMAP::FetchJob::FetchScope which, guess what, fetches full mail headers :). I will then change the IMAP resource to use this instead of the "Headers" scope.

As a result, we will download a bit more data than with just "Headers", but on the other hand, we will have perfectly working filters. If too many people complain, we can add an option to the IMAP resource.


Diffs
-----

  kimap/fetchjob.h 15a33b3 
  kimap/fetchjob.cpp 020ba4d 
  kimap/tests/fetchjobtest.cpp f04d15e 

Diff: http://git.reviewboard.kde.org/r/113010/diff/


Testing
-------


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/