[Kde-pim] Review Request 113313: coding style for akonadi

Dan Vrátil dvratil at redhat.com
Thu Oct 31 21:01:27 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113313/#review42751
-----------------------------------------------------------


The indentation is still not correct.

Looks for example on AkonadiServer::init(). Content of this method is indented by 4 spaces. But in AkonadiServer::createDatabase(), the content is indented only by 2 spaces from the left. You increased indentation of nested blocks, but forgot to fix indentation of the top-level blocks within methods too.

- Dan Vrátil


On Oct. 31, 2013, 5:22 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113313/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 5:22 p.m.)
> 
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> next job for akonadi/server/src
> 
> Please have anew look here
> 
> 
> Diffs
> -----
> 
>   server/src/akonadi.cpp 8433de1 
> 
> Diff: http://git.reviewboard.kde.org/r/113313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list