[Kde-pim] Review Request 113313: coding style for akonadi

Dan Vrátil dvratil at redhat.com
Thu Oct 24 12:43:32 BST 2013



> On Oct. 18, 2013, 8:18 a.m., Dan Vrátil wrote:
> > Could you please take a look on the indentation of some  of the methods here? Some are indented by two spaces, some by four (I think we use two spaces by default (?)).
> 
> Guy Maurel wrote:
>     not yet.
>     This is a difficult discussion!
>     Let us time for that at Brno.
> 
> Guy Maurel wrote:
>     Have a look to the mailinglist thread beginning at:
>     [Kde-pim]  Kdepim coding style: indentation
>     Date: 2011-03-01 14:46

Uh, I was not even around KDE PIM back then :-D. Ok, so if it does not matter, then please indent all methods to 4 spaces, since most of the file is using 4 spaces instead of 2.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113313/#review41928
-----------------------------------------------------------


On Oct. 23, 2013, 4:38 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113313/
> -----------------------------------------------------------
> 
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> next job for akonadi//
> 
> 
> Diffs
> -----
> 
>   server/src/akonadi.cpp 8433de1 
> 
> Diff: http://git.reviewboard.kde.org/r/113313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list