[Kde-pim] Review Request 113074: fix parsing inline gpg signed messages (SUSE bnc#667717)

[Ondrej Holecek]

> On Oct. 3, 2013, 9:58 p.m., Sandro Knauß wrote:
> > Thanks for the patch! I don't like you overwrite the log-file entry for all circumstances.
> > For example I use log-file with a valid log-file and I have no problem with signatures and inline messages.
> > 
> > The right way would be to use gpgme for inline messages (rewrite ObjectTreeParser::writeBodyStr), like it is used for SMIME and PGP Mime. 
> > 
> > Btw. the patch would also close #247657 and #291890 from bug.kde.org.

That's true, I don't exactly like this approach too, I just didn't imagine any other way without rewriting kpgpbaseG class.
I'll look into using gpgme, just give me a few days. :) Should I discard this review request or can I reuse it later?

Btw. just wondering, what log-file do you use that it works for you? From my experiments set log-file suppressed STDERR output libkpgp depends on, no matter what I set it to.


- Ondrej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113074/#review41188
-----------------------------------------------------------


On Oct. 3, 2013, 4:19 p.m., Ondrej Holecek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113074/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 4:19 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> fix parsing of inline gpg signed messages ( https://bugzilla.novell.com/show_bug.cgi?id=667717 )
> - when user has set log-file parameter in his ~/.gnupg/gpg.conf, kmail does not detect encrypted/signed messages in case of text/plain message with inline signatures
> 
> I fixed this by adding --logger-file parameter to gpg calls. Although this parameter should take one argument, it works without specifying any and then set log output properly to expected STDERR.
> 
> 
> Diffs
> -----
> 
>   libkpgp/kpgpbaseG.cpp 010842d2318d81ed39e1152e1bd0ce8e60276a46 
> 
> Diff: http://git.reviewboard.kde.org/r/113074/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ondrej Holecek
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/