[Kde-pim] Review Request 112941: after all the hints I get, this is a second run, part 2
Dan Vrátil
dvratil at redhat.com
Sat Oct 12 12:22:06 BST 2013
> On Oct. 1, 2013, 7:27 p.m., Dan Vrátil wrote:
> > rds/bridgeconnection.cpp, line 115
> > <http://git.reviewboard.kde.org/r/112941/diff/1/?file=192414#file192414line115>
> >
> > Please add space after (struct sockaddr*) and remove the space after sizeof() - we use it as a method instead of operator
>
> Guy Maurel wrote:
> a coding style rule says: "... a blank after each keyword ..."
> How to make here the difference?
Hmm, you are right. I saw it as a method instead of keyword.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112941/#review41070
-----------------------------------------------------------
On Oct. 11, 2013, 7:14 p.m., Guy Maurel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112941/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 7:14 p.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Krammer.
>
>
> Repository: akonadi
>
>
> Description
> -------
>
> to complete the job
>
>
> Diffs
> -----
>
> rds/bridgeconnection.cpp ee31ed1
> rds/main.cpp d608a93
>
> Diff: http://git.reviewboard.kde.org/r/112941/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guy Maurel
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list