[Kde-pim] trying to understand akonadi
Kevin Krammer
krammer at kde.org
Sat Oct 19 11:07:53 BST 2013
Hi Martin,
On Samstag, 2013-10-19, 09:38:55, Martin Koller wrote:
> I think I found the bug - actually two problems:
>
> 1.) MBox::load() reads the mbox file size BEFORE the file is locked, which
> leads to the problem that the value it stores is wrong when finally the
> lock is done when inbetween the mbox file is filled.
> => https://git.reviewboard.kde.org/r/113340/
Good catch!
> 2.) The way the mbox resource calls the lockfile command is a problem:
> It uses -l20, which will force remove the lockfile after 20 seconds - even
> when my mail download program is still active and writes into the mbox file.
> I solved this now so that my downloader stores all downloaded mails into a
> tmp mbox and when finished it will lock the final mailbox and transfer all
> newly downloaded mails into the final one - to keep the lock as short as
> possible.
I wonder if the resource could improve that by working asynchronously, e.g.
watching for the lockfile to disappear.
Anyway, thanks for the analysis and fixing!
Cheers,
Kevin
--
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20131019/598e0ec7/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list